Support for RGB and RGBA values

Josh's Avatar

Josh

27 Jul, 2011 04:38 AM

I am seeing potential errors from RGB values is there a way to correct this?

  1. 1 Posted by Josh on 27 Jul, 2011 04:49 AM

    Josh's Avatar

    Also this is causing an error

    input:-moz-placeholder {
    padding: 10px; font-size: .875em; line-height: 1.4; }

    error output
    A PHP Error was encountered

    Severity: Notice

    Message: Undefined variable: this

    Filename: tree/SassPropertyNode.php

    Line Number: 189

    Fatal error: Uncaught exception 'SassPropertyNodeException' with message 'Properties can not be assigned at root level' in /home/nedcremi/public_html/nc_admin/expressionengine/third_party/sassee/libraries/sass/tree/SassPropertyNode.php:189 Stack trace: #0 /home/nedcremi/public_html/nc_admin/expressionengine/third_party/sassee/libraries/sass/SassParser.php(543): SassPropertyNode::isa(Object(stdClass), '') #1 /home/nedcremi/public_html/nc_admin/expressionengine/third_party/sassee/libraries/sass/SassParser.php(516): SassParser->getNode(Object(SassPropertyNode)) #2 /home/nedcremi/public_html/nc_admin/expressionengine/third_party/sassee/libraries/sass/SassParser.php(519): SassParser->buildTree(Object(SassPropertyNode)) #3 /home/nedcremi/public_html/nc_admin/expressionengine/third_party/sassee/libraries/sass/SassParser.php(519): SassParser->buildTree(Object(SassRuleNode)) #4 /home/nedcremi/public_html/nc_admin/expressionengine/third_party/sassee/libraries/sass/SassParser.php(506): SassParser->buildTree(Object(SassRootNode)) #5 in /home/nedcremi/public_html/nc_admin/expressionengine/third_party/sassee/libraries/sass/tree/SassPropertyNode.php on line 189

  2. 2 Posted by Josh on 27 Jul, 2011 05:03 AM

    Josh's Avatar

    Also potentially seeing media queries be stripped from this:

    @media only screen and (min-width: 768px) { }

    to this:

    @media { }

  3. Support Staff 3 Posted by Wouter Vervloet on 27 Jul, 2011 05:43 PM

    Wouter Vervloet's Avatar

    Hi Josh, I'll look into this, hope to have an answer for you soon.

  4. 4 Posted by Josh on 27 Jul, 2011 07:17 PM

    Josh's Avatar

    Wouter, Thanks for making time to look into these issue for me. Happy to help clarify if that helps too.

  5. Support Staff 5 Posted by Wouter Vervloet on 27 Jul, 2011 07:29 PM

    Wouter Vervloet's Avatar

    Hi Josh,

    The rgb and placeholder bugs have been fixed. There were some bugs in the parser I'm using.

    New version: https://github.com/AboutWout/sassee.ee2_addon

    Still working on the @media rules.

    Wouter

  6. Support Staff 6 Posted by Wouter Vervloet on 27 Jul, 2011 07:45 PM

    Wouter Vervloet's Avatar

    And... I fixed the @media bug too. Seems I might need to start looking for a new SASS parser for PHP. This one seems to miss a few key components.

  7. 7 Posted by Josh on 27 Jul, 2011 08:46 PM

    Josh's Avatar

    You rock. Thanks for fixing this so quickly. I will update tonight and let you know if I run into any other issues.

  8. Support Staff 8 Posted by Wouter Vervloet on 27 Jul, 2011 09:57 PM

    Wouter Vervloet's Avatar

    I've used your test-cases for debugging, so at the very least it won't choke on those rules anymore.

  9. 9 Posted by Josh on 28 Jul, 2011 03:34 PM

    Josh's Avatar

    So far everything is solid. If I come across any new issues I make a new ticket but you are welcome to close this issue. Thanks again for your stellar support.

  10. Support Staff 10 Posted by Wouter Vervloet on 28 Jul, 2011 04:37 PM

    Wouter Vervloet's Avatar

    Glad everything is working so far.

  11. Wouter Vervloet closed this discussion on 28 Jul, 2011 04:37 PM.

Comments are currently closed for this discussion. You can start a new one.

Keyboard shortcuts

Generic

? Show this help
ESC Blurs the current field

Comment Form

r Focus the comment reply box
^ + ↩ Submit the comment

You can use Command ⌘ instead of Control ^ on Mac